Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxQueueSize wasn't respected when capturing events #116

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Mar 12, 2024

💡 Motivation and Context

https://posthog.slack.com/archives/C0643MHR56X/p1710247917392199

similar to v3.2.3, I checked that no other config is missing from the last major version during merges and repo changes.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto changed the title fix: maxQueueSize wasnt respected when capruging events maxQueueSize wasn't respected when capturing events Mar 12, 2024
@marandaneto marandaneto requested a review from a team March 12, 2024 13:41
@marandaneto marandaneto marked this pull request as ready for review March 12, 2024 13:41
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@marandaneto marandaneto merged commit ab78945 into main Mar 12, 2024
8 checks passed
@marandaneto marandaneto deleted the fix/maxQueueSize branch March 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants