chore: silence shared warning for strict concurrency #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Closes #127
Draft PR trying to silence all warnings for the SDK as well #128
That will likely require a iOS SDK v4 with major changes, but not worth for now until we are able to drop older iOS/Swift versions support and start using async/await, all sendable, etc.
nonisolated(unsafe)would be better as well instead of the whole class but that requires Swift >= 5.10 sadly.Edit:
nonisolated(unsafe)is possible using a compile directive and checking the Swift version💚 How did you test it?
📝 Checklist