Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow anonymous id generation to be configurable #133

Merged
merged 3 commits into from
May 21, 2024
Merged

allow anonymous id generation to be configurable #133

merged 3 commits into from
May 21, 2024

Conversation

jimexist
Copy link
Contributor

@jimexist jimexist commented May 20, 2024 •
edited
Loading

💡 Motivation and Context

this makes it aligned with the js/ts sdk

💚 How did you test it?

swift test

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@jimexist jimexist requested a review from marandaneto as a code owner May 20, 2024 06:36
@jimexist jimexist mentioned this pull request May 20, 2024
Merged
4 tasks
@marandaneto
Copy link
Member

Thanks for the PR @jimexist
Could you add a test to validate the behavior? PostHogSessionManagerTest would be the file I think

@marandaneto
Copy link
Member

For the lint issue: #134

@marandaneto marandaneto merged commit dcb2b1d into PostHog:main May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimexist @marandaneto