Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename groupProperties to groups for capture methods #140

Merged
merged 7 commits into from
Jun 4, 2024
Merged

fix: rename groupProperties to groups for capture methods #140

merged 7 commits into from
Jun 4, 2024

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Similar PostHog/posthog-android#139

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review June 4, 2024 06:54
@marandaneto marandaneto requested a review from a team June 4, 2024 06:55
@marandaneto
Copy link
Member Author

lint fixed by #141

@marandaneto marandaneto merged commit 7158936 into main Jun 4, 2024
5 of 6 checks passed
@marandaneto marandaneto deleted the fix/capture-groups branch June 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daibhin daibhin daibhin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @daibhin