chore: replay screenshot #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Jun 11, 2024
|
|
||
| logger.info("Requesting beers list...") | ||
| URLSession.shared.dataTask(with: url) { _, _, _ in | ||
| // guard let url = URL(string: "https://api.punkapi.com/v2/beers") else { |
There was a problem hiding this comment.
this API does not exist anymore, the sample has to be changed
marandaneto
commented
Jun 11, 2024
Comment on lines
+289
to
+290
| // TODO: add debouncer with debouncerDelayMs to take into account how long it takes to execute the | ||
| // snapshot method |
There was a problem hiding this comment.
since you cannot offload this from the main thread, a debouncer mechanism would be handy, can be separated to PR to get this out of the door since the timer calls snapshot every 500ms already instead of for every frame
marandaneto
commented
Jun 11, 2024
| @@ -96,6 +96,8 @@ | |||
| windowViews.setObject(snapshotStatus, forKey: view) | |||
| } | |||
|
|
|||
| // TODO: IncrementalSnapshot, type=2 | |||
There was a problem hiding this comment.
probably not needed if we make the screenshot the default option since it is always a single image anyway, unless at some point we try to optimize the data transfer by breaking a full image in tiles and only sending the ones that have changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist