Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate UUID from v4 to v7 #145

Merged
merged 5 commits into from
Jun 17, 2024
Merged

chore: migrate UUID from v4 to v7 #145

merged 5 commits into from
Jun 17, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jun 17, 2024

💡 Motivation and Context

Closes #144
Apple only has uuid v4
AFAIK there's no popular uuid v7 package for iOS
Inspired and adapted from https://github.com/nthState/UUIDV7/tree/main

💚 How did you test it?

Validated here https://uuidgenerator.dev/uuid-validator

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team June 17, 2024 10:23
@marandaneto marandaneto marked this pull request as ready for review June 17, 2024 11:49
@marandaneto
Copy link
Member Author

@daibhin I did a few more changes to match the Android impl. and added a sorting test as well, can you double-check? thanks.

Copy link

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Not super familiar with the uuid generation spec but is well documented / tested so I think t's gtg

@marandaneto marandaneto merged commit 080bacd into main Jun 17, 2024
6 checks passed
@marandaneto marandaneto deleted the chore/uuid-v4-v7 branch June 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use uuidv7 instead of uuidv4
2 participants