Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recording: use non deprecated methods for getCurrentWindow if available #178

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Sep 3, 2024

💡 Motivation and Context

sometimes the recordings are black
one assumption is that the heuristics algo to detect the current window is wrong
this one uses the latest methods available from iOS 15 otherwise fallback to another one

💚 How did you test it?

running the app with storyboard and swiftui

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as ready for review September 3, 2024 13:12
@marandaneto marandaneto requested a review from a team September 3, 2024 13:13
@marandaneto marandaneto merged commit 967a3df into main Sep 3, 2024
9 checks passed
@marandaneto marandaneto deleted the fix/current-window branch September 3, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants