recording: send meta event again if session rotates #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
The problem: If meta event is missing, the replay will be just a black screen because rrweb hides everything if no meta event is provided
We cache the window and the status object in a weak reference.
If the session rotates, and the window and status object are still in memory, we won't be sending the meta event again
Every time the session rotates, we clear the weak reference object so meta events will be sent again
💚 How did you test it?
Running
📝 Checklist