fix: feature_flag_called after reloadFeatureFlags #232
+75
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisj
commented
Nov 5, 2024
marandaneto
reviewed
Nov 6, 2024
marandaneto
reviewed
Nov 6, 2024
marandaneto
reviewed
Nov 6, 2024
marandaneto
reviewed
Nov 6, 2024
marandaneto
reviewed
Nov 6, 2024
Co-authored-by: Manoel Aranda Neto <5731772+marandaneto@users.noreply.github.com>
ioannisj
force-pushed
the
fix/trigger-feature_flag_called
branch
from
8dd7afb to
4a839d2
Compare
|
Hey just reverted changes. So we now just clear the set when flags are reloaded |
marandaneto
reviewed
Nov 7, 2024
marandaneto
reviewed
Nov 7, 2024
marandaneto
reviewed
Nov 7, 2024
marandaneto
reviewed
Nov 7, 2024
nice, did another pass and left a few comments |
marandaneto
approved these changes
Nov 7, 2024
marandaneto
reviewed
Nov 7, 2024
| @@ -10,18 +10,21 @@ import Nimble | |||
| import Quick | |||
|
|
|||
| @testable import PostHog | |||
| import XCTest | |||
There was a problem hiding this comment.
was that missing before? i think its not needed when using Nimble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Relates to: #211
Clear 'flagCallReported'' after reload so that $feature_flag_called can be captured
💚 How did you test it?
📝 Checklist