-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use global frame on wireframe views #250
Conversation
added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a last comment but feel free to make your judgment LGTM
# Conflicts: # CHANGELOG.md
@@ -448,6 +453,8 @@ | |||
wireframe.disabled = !button.isEnabled | |||
|
|||
if let text = button.titleLabel?.text { | |||
// NOTE: this will create a ghosting effect since text will also be captured in child UILabel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will create an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Motivation and Context
Closes #231
This issue was a bit challenging to uncover, but the solution turned out to be quite straightforward. After digging into the frontend code, I realized we always use
position: fixed
when styling nodes. To ensure the wireframe renders correctly, we need to convert all view frames to global screen coordinates.Before
After
💚 How did you test it?
Locally with some sample projects
📝 Checklist