Shift responsibility of IDFA collection to clients

PostHog/Classes/Internal/PHGPostHogIntegration.m

@@ -154,8 +154,8 @@ - (NSDictionary *)staticContext
     if (NSClassFromString(PHGAdvertisingClassIdentifier)) {
         dict[@"$device_adCapturingEnabled"] = @(GetAdCapturingEnabled());
     }
-    if (self.configuration.enableAdvertisingCapturing) {
-        NSString *idfa = PHGIDFA();
+    if (self.configuration.enableAdvertisingCapturing && self.configuration.adSupportBlock != nil) {
+        NSString *idfa = self.configuration.adSupportBlock();
         if (idfa.length) dict[@"$device_advertisingId"] = idfa;
     }
 

PostHog/Classes/Internal/PHGPostHogUtils.h

@@ -32,8 +32,6 @@ void PHGLog(NSString *format, ...);
 
 JSON_DICT PHGCoerceDictionary(NSDictionary *_Nullable dict);
 
-NSString *_Nullable PHGIDFA(void);
-
 NSString *PHGEventNameForScreenTitle(NSString *title);
 
 // Deep copy and check NSCoding conformance

PostHog/Classes/Internal/PHGPostHogUtils.m

@@ -1,5 +1,4 @@
 #import "PHGPostHogUtils.h"
-#import <AdSupport/ASIdentifierManager.h>
 
 static BOOL kPostHogLoggerShowLogs = NO;
 
@@ -164,27 +163,6 @@ static id PHGCoerceJSONObject(id obj)
     return PHGCoerceJSONObject(dict);
 }
 
-NSString *PHGIDFA()
-{
-    NSString *idForAdvertiser = nil;
-    Class identifierManager = NSClassFromString(@"ASIdentifierManager");
-    if (identifierManager) {
-        SEL sharedManagerSelector = NSSelectorFromString(@"sharedManager");
-        id sharedManager =
-            ((id (*)(id, SEL))
-                 [identifierManager methodForSelector:sharedManagerSelector])(
-                identifierManager, sharedManagerSelector);
-        SEL advertisingIdentifierSelector =
-            NSSelectorFromString(@"advertisingIdentifier");
-        NSUUID *uuid =
-            ((NSUUID * (*)(id, SEL))
-                 [sharedManager methodForSelector:advertisingIdentifierSelector])(
-                sharedManager, advertisingIdentifierSelector);
-        idForAdvertiser = [uuid UUIDString];
-    }
-    return idForAdvertiser;
-}
-
 NSString *PHGEventNameForScreenTitle(NSString *title)
 {
     return [[NSString alloc] initWithFormat:@"Viewed %@ Screen", title];

PostHog/Classes/PHGPostHogConfiguration.h

@@ -72,6 +72,18 @@ typedef NSMutableURLRequest *_Nonnull (^PHGRequestFactory)(NSURL *_Nonnull);
  */
 @property (nonatomic, assign) BOOL enableAdvertisingCapturing;
 
+/**
+ * Sets a block to be called when IDFA / AdSupport identifier is created.
+ * This is to allow for apps that do not want ad tracking to pass App Store guidelines in certain categories while
+ * still allowing apps that do ad tracking to continue to function.
+ *
+ * Example:
+ *      configuration.adSupportBlock = ^{
+ *          return [[ASIdentifierManager sharedManager] advertisingIdentifier];
+ *      }
+ */
+@property (nonatomic, copy, nullable) NSString * _Nonnull (^adSupportBlock)(void);
+
 /**
  * The number of queued events that the posthog client should flush at. Setting this to `1` will not queue any events and will use more battery. `20` by default.
  */

PostHog/Classes/PHGPostHogConfiguration.m

@@ -52,6 +52,7 @@ - (instancetype)init
     if (self = [super init]) {
         self.shouldUseLocationServices = NO;
         self.enableAdvertisingCapturing = YES;
+        self.adSupportBlock = nil;
         self.shouldUseBluetooth = NO;
         self.flushAt = 20;
         self.flushInterval = 30;

PostHogTests/PostHogTests.swift

@@ -34,6 +34,7 @@ class PostHogTests: QuickSpec {
       expect(posthog.configuration.host) == URL(string: "https://app.posthog.com")
       expect(posthog.configuration.shouldUseLocationServices) == false
       expect(posthog.configuration.enableAdvertisingCapturing) == true
+      expect(posthog.configuration.adSupportBlock).to(beNil())
       expect(posthog.configuration.shouldUseBluetooth) == false
       expect(posthog.configuration.libraryName) == "posthog-ios"
       expect(posthog.configuration.libraryVersion) == PHGPostHog.version()
@@ -54,6 +55,7 @@ class PostHogTests: QuickSpec {
       expect(posthog.configuration.host) == URL(string: "https://testapp.posthog.test")
       expect(posthog.configuration.shouldUseLocationServices) == false
       expect(posthog.configuration.enableAdvertisingCapturing) == true
+      expect(posthog.configuration.adSupportBlock).to(beNil())
       expect(posthog.configuration.shouldUseBluetooth) == false
       expect(posthog.configuration.libraryVersion) == "posthog-ios-version"
       expect(posthog.configuration.libraryName) == "posthog-ios-test"