Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Issues with main screen and tests #55

Merged
merged 7 commits into from
Jun 2, 2023
Merged

fix: Issues with main screen and tests #55

merged 7 commits into from
Jun 2, 2023

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Jun 1, 2023 •
edited
Loading

What does this PR do?

Supersedes #54
Closes #53

  • Fixes an issue with accessing the main screen by now using a more advanced check
  • Fixes a missing return in the httpclient that might have been causing confusing error messages
  • Ups the minimum iOS version to 11

@benjackwhite benjackwhite requested a review from EDsCODE June 1, 2023 08:07
@pixlwave pixlwave mentioned this pull request Jun 1, 2023
Closed
@benjackwhite benjackwhite merged commit 858fa85 into master Jun 2, 2023
@benjackwhite benjackwhite deleted the fix/shared-screen branch June 2, 2023 06:26
@pixlwave pixlwave mentioned this pull request Jun 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Initializing PostHog in a SwiftUI app results in accent color not being respected
1 participant
@benjackwhite