CoreTelephony should not be added to tvOS builds #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Sep 6, 2023
| @@ -806,7 +806,11 @@ | |||
| "CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development"; | |||
| DEVELOPMENT_TEAM = UG8G36W2HB; | |||
| INFOPLIST_FILE = PostHogTests/Info.plist; | |||
| LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks"; | |||
| LD_RUNPATH_SEARCH_PATHS = ( | |||
There was a problem hiding this comment.
The changes below are done automatically by Xcode
benjackwhite
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CoreTelephony should not be added to tvOS builds
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
When integrating the SDK with PMs such as Carthage, the PM tries to use CoreTelephony for tvOS as well and it fails
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: