isFeatureEnabled now returns false if disabled #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Oct 8, 2023
| @@ -2,7 +2,7 @@ import UIKit | |||
| import PostHog | |||
|
|
|||
| // Use your own apiKey! | |||
| let PostHog = PHGPostHog(configuration: PHGPostHogConfiguration(apiKey: "b2XoQDHA5YhWQAjr2FZ4qIckgyEqXyY8")) | |||
| let PostHog = PHGPostHog(configuration: PHGPostHogConfiguration(apiKey: "_6SG-F7I1vCuZ-HdJL3VZQqjBlaSb1_20hDPwqMNnGI")) | |||
marandaneto
commented
Oct 8, 2023
| @@ -27,13 +27,24 @@ class FeatureFlagTests: QuickSpec { | |||
| it("checks flag is enabled") { | |||
| _ = stubRequest("POST", "https://app.posthog.test/decide/?v=3" as LSMatcheable) | |||
| .andReturn(200)? | |||
| .withBody("{\"featureFlags\":{\"some-flag\":\"true\"}}" as LSHTTPBody); | |||
| .withBody("{\"featureFlags\":{\"some-flag\": true}}" as LSHTTPBody); | |||
There was a problem hiding this comment.
String escaping was making the test wrong, fixed all of them.
marandaneto
commented
Oct 8, 2023
PostHogTests/PostHogTests.swift
Outdated
| @@ -97,22 +97,22 @@ class PostHogTests: QuickSpec { | |||
|
|
|||
| it("fires Application Opened during UIApplicationWillEnterForeground") { | |||
| testMiddleware.swallowEvent = true | |||
| NotificationCenter.default.post(name: UIApplication.willEnterForegroundNotification, object: testApplication) | |||
| NotificationCenter.default.post(name: NSNotification.Name.UIApplicationWillEnterForeground, object: testApplication) | |||
There was a problem hiding this comment.
UIApplication.x is deprecated in favor of NSNotification.Name.x
benjackwhite
reviewed
Oct 9, 2023
benjackwhite
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
isFeatureEnabledshould returnfalseif feature flag is disabledWhere should the reviewer start?
PHGPostHog.mHow should this be manually tested?
Demo project has one flag for each case, you can just call
isFeatureEnabledwith them.Any background context you want to provide?
Relates to PostHog/posthog-android#42
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: