Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not report dupe Application Opened event during the first time #95

Merged
merged 5 commits into from
Jan 11, 2024
Merged

Do not report dupe Application Opened event during the first time #95

merged 5 commits into from
Jan 11, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jan 10, 2024 •
edited
Loading

💡 Motivation and Context

Application Opened event was being reported twice when opening for the first time.
The OS sends 2 notifications and we were calling the method in both of them

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto requested a review from a team January 10, 2024 13:13
pauldambra
pauldambra approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@marandaneto marandaneto merged commit 754e8ac into main Jan 11, 2024
7 checks passed
@marandaneto marandaneto deleted the fix/dupe-app-opened branch January 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marandaneto @pauldambra