Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typing of maskTextFn #1122

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: typing of maskTextFn #1122

merged 2 commits into from
Apr 9, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Apr 9, 2024

Changes

Incorrect type called out in PostHog/posthog#20100 (comment)

@daibhin daibhin added the bump patch Bump patch version when this PR gets merged label Apr 9, 2024
@daibhin daibhin requested a review from a team April 9, 2024 09:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 947 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 225 kB
dist/array.js 126 kB
dist/es.js 127 kB
dist/exception-autocapture.js 12.2 kB
dist/module.js 127 kB
dist/recorder-v2.js 105 kB
dist/recorder.js 105 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@daibhin daibhin mentioned this pull request Apr 9, 2024
Closed
@daibhin daibhin merged commit 5cb3311 into main Apr 9, 2024
11 checks passed
@daibhin daibhin deleted the dn-fix/mask-text-type branch April 9, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @marandaneto