Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move heatmaps out of preview #1156

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: Move heatmaps out of preview #1156

merged 1 commit into from
Apr 26, 2024

Conversation

benjackwhite
Copy link
Collaborator

Changes

Makes the heatmap config value a standard option

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

@benjackwhite benjackwhite requested a review from pauldambra April 25, 2024 12:32
@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Apr 25, 2024 0:33am

@benjackwhite benjackwhite added bump minor Bump minor version when this PR gets merged bump patch Bump patch version when this PR gets merged and removed bump minor Bump minor version when this PR gets merged bump patch Bump patch version when this PR gets merged labels Apr 25, 2024
@github-actions GitHub Actions
Copy link

Size Change: -24 B (0%)

Total Size: 976 kB

Filename Size Change
dist/array.full.js 233 kB -6 B (0%)
dist/array.js 131 kB -6 B (0%)
dist/es.js 131 kB -6 B (0%)
dist/module.js 131 kB -6 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12.2 kB
dist/recorder-v2.js 108 kB
dist/recorder.js 108 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

pauldambra
pauldambra approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@benjackwhite benjackwhite merged commit e8ace28 into main Apr 26, 2024
13 checks passed
@benjackwhite benjackwhite deleted the fix/heatmaps-config branch April 26, 2024 08:51
@simlarsen simlarsen mentioned this pull request May 18, 2024
Merged
@Bad3r Bad3r mentioned this pull request May 20, 2024
Open
@simlarsen simlarsen mentioned this pull request May 21, 2024
Merged
This was referenced May 22, 2024
Open
Open
Open
This was referenced May 29, 2024
Open
Open
This was referenced Jun 11, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjackwhite @pauldambra