fix(survey): Fix issue with shuffling questions on every render

[Phanatic]

Changes

This PR makes a fix to followup on #1177 where we discovered a bug that we weren't shuffling questions correctly.
The bug was in the survey rendering where we would repeatedly shuffle questions, causing us to sometimes lose questions when the component re-renders. This is now fixed by using the useMemo react hook to shuffle the questions for a given Survey only once.

Checklist

• Tests for new code (see advice on the tests we use)
• Accounted for the impact of any changes across different browsers
• Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
posthog-js	✅ Ready (Inspect)	Visit Preview	May 12, 2024 2:53am

[github-actions]

Size Change: +58 B (+0.01%)

Total Size: 976 kB

Filename	Size	Change
dist/surveys-module-previews.js	57.7 kB	+29 B (+0.05%)
dist/surveys.js	59.3 kB	+29 B (+0.05%)

ℹ️ View Unchanged

Filename	Size
dist/array.full.js	234 kB
dist/array.js	132 kB
dist/es.js	132 kB
dist/exception-autocapture.js	12.2 kB
dist/module.js	132 kB
dist/recorder-v2.js	108 kB
dist/recorder.js	108 kB

_{compressed-size-action}

[neilkakkar]

reasonable, nice!