feat: add renderSurvey option #1324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +4.08 kB (+0.35%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
dmarticus
reviewed
Jul 30, 2024
dmarticus
reviewed
Jul 30, 2024
|
|
||
| export default function Survey() { | ||
| const posthog = usePostHog() | ||
| const [surveys, setSurveys] = useState([] as unknown as Survey[]) |
There was a problem hiding this comment.
FYI, when I try to build this locally, I get a failure:
./pages/survey.tsx:6:61
Type error: 'Survey' refers to a value, but is being used as a type here. Did you mean 'typeof Survey'?
4 | export default function Survey() {
5 | const posthog = usePostHog()
> 6 | const [surveys, setSurveys] = useState([] as unknown as Survey[])
| ^
7 | const [selectedSurvey, setSelectedSurvey] = useState('0190bc7b-7096-0000-126d-1e5e7021a80e')
8 | const handleChange = (event) => {
9 | setSelectedSurvey(event.target.value)
because I don't think the playground has access to these types.
dmarticus
approved these changes
Jul 30, 2024
|
|
||
| export default function Survey() { | ||
| const posthog = usePostHog() | ||
| const [surveys, setSurveys] = useState([] as unknown as Survey[]) |
This is a bug fix for the scenario where we weren't removing a survey from the activated surveys list once the survey is shown.
* Add debug logic for set_config * Improve startup debug log * Add logging to persistence
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a
posthog.renderSurvey('[survey-id]', '[js-selector]', (survey) => !survey && console.log('survey not found'))function which will render any survey on an element on a page. This will allow users to use surveys as forms.Decided to go unformatted so that the formatting will match wherever it's embedded
Checklist