feat(flags): give users the ability to suppress override warning logs, if desired #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @dmarticus! 👋 |
|
Size Change: +244 B (+0.02%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Phanatic
approved these changes
Jul 30, 2024
| if (!this.instance.__loaded || !this.instance.persistence) { | ||
| return logger.uninitializedWarning('posthog.feature_flags.override') | ||
| } | ||
|
|
||
| this._override_warning = false | ||
| this._override_warning = suppressWarning |
There was a problem hiding this comment.
this _override_warning is confusing because for a value of false, we log the debug warning.
posthog-js/src/posthog-featureflags.ts
Lines 115 to 122 in 25713e9
Good fix here.
This was referenced Aug 22, 2024
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We've supported manually overriding feature flag values in the client for years (and our toolbar natively supports it), but since this override doesn't persist to the backend, we've historically always just treated this feature as a debug feature only. However, there's been a influx of support requests (on both Twitter and in our support inbox) that are asking about this feature, and one user explicitly mentioned that the feature would be perfect for his use case if it weren't for the debug warning and logs. I started a discussion about this in Slack, and if we decide that it's safe to give users the ability to remove these logs, this PR enables it.
Checklist