Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
By default rrweb only masks password fields by setting
maskAllInputs: false
andmaskInputOptions: { password: true }
Currently PostHog JS masks all inputs by default (
maskAllInputs: true
) and because of that has nomaskInputOptions
e.g.maskInputOptions: {}
Given the sensitivity of passwords I think we should still use the same default as rrweb for
maskInputOptions
. It might be a little confusing to a customer why their passwords are still masked when they explicitly setmaskAllInputs: false
but I would rather confusion and protection over unintentionally disabling password masking.There is a little bit of an overlap in these two parameters which is the source of confusion, but as I said above, a customer should really know when they're explicitly revealing password fields. I would argue we go a step further and always mask password fields because I can't think of a good reason to allow passwords to be captured but we can follow up with that