fix(surveys): fix textarea, and make it easier to query the survey question description in the DOM #1337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +276 B (+0.02%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
dmarticus
commented
Aug 1, 2024
| @@ -23,7 +23,7 @@ export function QuestionHeader({ | |||
| <div className="survey-question">{question}</div> | |||
| {description && | |||
| renderChildrenAsTextOrHtml({ | |||
| component: h('div', { className: 'description' }), | |||
| component: h('div', { className: 'survey-question-description' }), | |||
There was a problem hiding this comment.
makes our survey question descriptions easier to query in the DOM, see: PostHog/posthog#24143
This was referenced Aug 23, 2024
This was referenced Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Our textarea looked super bad, not sure if it's always been like that but I hate what it looks like now. Reported here: https://posthog.slack.com/archives/C074A08LP1B/p1722508627577449
Before:
After:
In addition to that change, I also fixed our survey question description selectors. This will help make our survey visual regression tests less flaky. Those changes ship with the posthog changes here:
Checklist