Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force session recording to use lz64 #134

Merged
merged 2 commits into from
Nov 27, 2020
Merged

Force session recording to use lz64 #134

merged 2 commits into from
Nov 27, 2020

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Nov 27, 2020

Changes

  • Force session recording to use lz64 (as it would use base64 before /decide endpoint response)
  • Send library version + compression as headers
  • Add tests for payload sent to server

Checklist

  • Tests for new code (if applicable)
  • TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

@macobo
Force lz64 compression for session recording
ed81ce9 
The largest session recording event is the initial FULL_SNAPSHOT which
might happen before initial /decide response.

By forcing compression we make sure events reach us better.
@macobo
Send library version, compression as headers, test payload
80624ca
@macobo macobo requested a review from timgl November 27, 2020 11:56
@timgl timgl merged commit 027fa8c into master Nov 27, 2020
@timgl timgl deleted the compression branch November 27, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgl timgl Awaiting requested review from timgl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macobo @timgl