Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): textarea border box was being set in the preview but not in the surveys rendered on user websites #1340

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

dmarticus
Copy link
Contributor

@dmarticus dmarticus commented Aug 5, 2024

Changes

Issue identified here: https://posthog.slack.com/archives/C074A08LP1B/p1722845257000019?thread_ts=1722508627.577449&cid=C074A08LP1B

This issue came from me trying to fix the textarea size for free response surveys. My fix made the survey preview rendering work correctly, but it was too wide for the popover rendering (which is more important; that's the thing the end users see!)

Before:

image

and

Screenshot 2024-08-05 at 7 31 55 AM

I fixed this to add an explicit border box into the textarea. In the preview, it was inheriting a border box already, so this wasn't a problem, but since the rendered survey has a different DOM tree, with different stylings, it didn't work for end users.

This fix should work for both.

After (on page):

Screenshot 2024-08-05 at 7 47 27 AM

After (in preview section):

image

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 5, 2024 2:52pm

Copy link

github-actions bot commented Aug 5, 2024

Size Change: +117 B (+0.01%)

Total Size: 1.16 MB

Filename Size Change
dist/array.full.js 333 kB +39 B (+0.01%)
dist/surveys-preview.js 59.6 kB +39 B (+0.07%)
dist/surveys.js 65.7 kB +39 B (+0.06%)
ℹ️ View Unchanged
Filename Size
dist/array.js 154 kB
dist/exception-autocapture.js 10.4 kB
dist/main.js 154 kB
dist/module.js 154 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@dmarticus dmarticus requested a review from a team August 5, 2024 14:59
Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants