fix(surveys): textarea border box was being set in the preview but not in the surveys rendered on user websites #1340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issue identified here: https://posthog.slack.com/archives/C074A08LP1B/p1722845257000019?thread_ts=1722508627.577449&cid=C074A08LP1B
This issue came from me trying to fix the textarea size for free response surveys. My fix made the survey preview rendering work correctly, but it was too wide for the popover rendering (which is more important; that's the thing the end users see!)
Before:
and
I fixed this to add an explicit border box into the textarea. In the preview, it was inheriting a border box already, so this wasn't a problem, but since the rendered survey has a different DOM tree, with different stylings, it didn't work for end users.
This fix should work for both.
After (on page):
After (in preview section):