-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: default replay partial compression on #1445
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +495 B (+0.02%) Total Size: 2.81 MB
ℹ️ View Unchanged
|
const originalSize = estimateSize(event) | ||
if (originalSize < PARTIAL_COMPRESSION_THRESHOLD) { | ||
return event | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we pretty frequently get small enough snapshots that they're bigger when compressed so we can leave them be
Hi @pauldambra, We were going from 1.165.0 to 1.178.0 with a production release today, but we ended up being blocked by the console stack traces relating to undefined length across any event or page change. I can confirm that without any changes to the our codebase, this PR results in endless console errors. We actually had to roll a release back this afternoon, but after debugging this further we finally narrowed down the issue to this PR. The errors here show up on every pageview, event, navigation, etc. The workaround to proceed was to adjust our posthog.init statement to add compress_events: false Have you received any other reports of this issue? Ive been going through different package versions for a while and the exceptions are showing up with this PR and all releases from 1.166.0 |
hey @kitsirota We've not had any reports of that and it's been the default for a month now. Are you able to open a ticket from in-app support? We'd need to take a look at the site and see what was happening. There was a similar looking bug but that was fixed in 1.166.2 so shouldn't be possible in 1.178.0 |
Partial compression of large rrweb events will make them more reliably ingestable
We've had this on for days now, and some users have tested it
Let's default it on
Clicked around in PH app and saved ~1MB in 2 minutes of recording