-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for UMD and ESM #166
Conversation
Updated the build for `posthog-js/react` so it now outputs UMD and ESM
@macobo @stevenphaedonos please have a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution @weyert, I've left some comments. I was also wondering if you could provide some details about your use-case where the es2015 module was insufficient?
@stevenphaedonos I have updated it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the redundant line in files
of package.json
and it looks good to me. Do you have any comments @macobo?
I will take a look hopefully sometime soon. On a high level I think we might end up rolling all of the builds into a single rollup file. |
Removed it! Thank you :) |
All good? |
Any news on this PR? Love to stop using my private build |
Sorry for this taking so long. To elaborate a bit on the cause:
I was hoping to take some time to clean all of this up properly but it seems this time is not going to be soon. I'll merge this as-is and deal with the fallout at a later date - while this does introduce a ton of technical debt and is untestable in current state, it is a useful change. PS: We've been waiting for a response on #114 as well for months. |
Updated the build for
posthog-js/react
so it now outputs UMD and ESMfixes #165
Changes
updated the build process for the React components so that it outputs both UMD and ESM format
Checklist