Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-flags): Enable experience continuity #404

Merged
merged 9 commits into from
Jun 28, 2022
Merged

feat(feature-flags): Enable experience continuity #404

merged 9 commits into from
Jun 28, 2022

Conversation

neilkakkar
Copy link
Contributor

Changes

Goes in after PostHog/posthog#10196 - client side support for persistent feature flags
...

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • TypeScript definitions (module.d.ts) updated and in sync with library exports (if applicable)

@neilkakkar neilkakkar added the bump minor Bump minor version when this PR gets merged label Jun 10, 2022
@neilkakkar neilkakkar mentioned this pull request Jun 23, 2022
Closed
@neilkakkar neilkakkar requested review from EDsCODE and rcmarron June 24, 2022 12:06
@neilkakkar neilkakkar marked this pull request as ready for review June 24, 2022 12:06
rcmarron
rcmarron approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@rcmarron rcmarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - tested it out, it works. Just the few comments below.

src/posthog-featureflags.js Outdated Show resolved Hide resolved
src/posthog-featureflags.js Outdated Show resolved Hide resolved
@neilkakkar
Copy link
Contributor Author

TestCafe is flaky, unrelated failure: #414

@neilkakkar neilkakkar merged commit 3f7526b into master Jun 28, 2022
@neilkakkar neilkakkar deleted the feature-flag-continuity branch June 28, 2022 11:53
@pauldambra
Copy link
Member

Saw this had merged and rushed to see how you'd fixed the flaky tests...

Much disappointment 🤣

@mariusandra
Copy link
Collaborator

We do need these tests working for IE11 support in this library, which is a reason some customers use us.

@macobo macobo mentioned this pull request Jul 12, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcmarron rcmarron rcmarron approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees
No one assigned
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neilkakkar @pauldambra @mariusandra @rcmarron