Remove deprecated datetime.utcnow() in favour of datetime.now(tz=tzutc())
#124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neilkakkar should I close this? |
|
i'll get this merged in, sorry this fell through the cracks! |
…e-deprecated-datetime-utcnow
neilkakkar
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented the function
datetime.utcnow()is deprecated and will be removed in future versions.They recommend using
datetime.now(timezone.utc)in its place. I decided to usetzutc()in this case as I see the project is usingpython-dateutilsand this might be prefered.This won't probably be removed in
3.13as it just been deprecated in3.12so it's low priority, though still something that needs to be updated as it emits annoying deprecation warnings.