Skip to content

fix(llma): cache cost calculation in the LangChain callback #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(llma): cache cost calculation in the LangChain callback #346

wants to merge 2 commits into from
+223 −7

Conversation

@skoob13
Copy link
Contributor

@skoob13 skoob13 commented Oct 24, 2025

Problem

LangChain passes input tokens as a sum of input and cached tokens, so we incorrectly calculate the total cost.

@skoob13 skoob13 requested a review from a team October 24, 2025 10:25
greptile-apps[bot]
greptile-apps bot reviewed Oct 24, 2025
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@skoob13