Have an option to send feature variants with the .capture(...) calls. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
reviewed
May 27, 2022
posthog/test/test_client.py
Outdated
| @@ -417,7 +417,7 @@ def test_feature_enabled_simple(self, patch_get, patch_decide): | |||
| @mock.patch("posthog.client.decide") | |||
| @mock.patch("posthog.client.get") | |||
| def test_feature_enabled_simple_is_false(self, patch_get, patch_decide): | |||
| client = Client(TEST_API_KEY) | |||
| client = Client(TEST_API_KEY, personal_api_key="test") | |||
There was a problem hiding this comment.
why'd you have to add this here? 🤔
There was a problem hiding this comment.
Ah ha, I was blindly adding the personal_api_key to all tests which mocked client.decide. No need in here.
added 2 commits
May 27, 2022 16:02
|
Hey @utkuzih , apologies for taking a while. I wanted to confirm that the solution for PostHog/posthog#9547 wouldn't impact this in any way. Doesn't seem like it anymore, so I'll get this merged first thing Monday :) |
|
It would be nice to have a test or two for the new functionality as well. I'll add these myself on Monday if you don't get to it by then. |
|
I couldn't push to your fork, so created a new PR instead 😅 . Thanks for working on this! |
|
@neilkakkar Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
send_feature_flags=Falseflag for theposthog.capture(...)call. Also added a new public function similar to the Javascript library:posthog.get_feature_variants(distinct_id, groups=None).