feat(docs): add zone recommendation for session recording #9897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@10kc-emilyk is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
|
Ah, this is amazing! Thank you for taking the time |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I notice that the session recorder is being improved so that this recommendation isnt necessary, although I think it could still remain as a recommendation when possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
My team and I ran into this performance/frozen page issue and tracked it down to angular change detection running with posthog session recording. I found a number of other issues related to this in rrweb, and there are some fixes where the recording should be using the un-zone.js-patched mutation observer, but it doesnt seem to be perfectly reliable:
angular/angular#26948
rrweb-io/rrweb#469
rrweb-io/rrweb#1384
getsentry/sentry-javascript#6946
Checklist
vercel.jsonUseful resources