feat(flags): Decide returns all flags, not just active flags #13616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be no risk to merge this as-is, as v3 isn't used anywhere yet, and v2 behaviour is unchanged |
EDsCODE
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #13601
Refactors
get_active_feature_flagsintoget_all_feature_flags, and updates appropriate call sites. The re-naming should ensure that we didn't miss it anywhere & tests should help catch any bugs here.Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?