Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hackathon-3000): use session query api #18218

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat(hackathon-3000): use session query api #18218

merged 2 commits into from
Oct 26, 2023

Conversation

thmsobrmlr
Copy link
Contributor

Problem

We've been using a mock for the sessions api.

Changes

This PR uses the query endpoint.

How did you test this code?

Tested locally

benjackwhite
benjackwhite approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made it 🏁 💪 🥳

@thmsobrmlr thmsobrmlr mentioned this pull request Oct 26, 2023
Open
15 tasks
@thmsobrmlr thmsobrmlr enabled auto-merge (squash) October 26, 2023 15:56
@thmsobrmlr thmsobrmlr merged commit ea68d3a into master Oct 26, 2023
73 checks passed
@thmsobrmlr thmsobrmlr deleted the sessions-use-query branch October 26, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@Twixes Twixes Awaiting requested review from Twixes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thmsobrmlr @benjackwhite