Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): data warehouse scene ui updates #21189

Merged
merged 5 commits into from
Mar 27, 2024
Merged

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Mar 27, 2024

Problem

  • no loading state for data warehouse tables
  • no refreshed at on info column
  • confusing when there's a lot of tables

Changes

  • add spinner
Screenshot 2024-03-27 at 12 33 23 PM
  • add last synced at on info column

  • group source types together

Screenshot 2024-03-27 at 2 50 05 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE mentioned this pull request Mar 27, 2024
24 tasks
Copy link
Contributor

github-actions bot commented Mar 27, 2024

Size Change: 0 B

Total Size: 824 kB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 824 kB

compressed-size-action

@EDsCODE EDsCODE changed the title fix(data-warehouse): add loading indicator for data warehouse tables fix(data-warehouse): data warehouse scene ui updates Mar 27, 2024
@EDsCODE EDsCODE merged commit ccee1fb into master Mar 27, 2024
134 of 136 checks passed
@EDsCODE EDsCODE deleted the dw-tree-loading branch March 27, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant