fix: revert even more rrweb #21821
Merged
fix: revert even more rrweb #21821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
approved these changes
Apr 24, 2024
daibhin
force-pushed
the
dn-fix/rrweb-correct-patch
branch
from
59b137d to
7373801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#21816 didn't work either 😢 I misapplied the patch
Changes
Added the correct code back
How did you test this code?
Very difficult to test because I cannot download recordings right now because the exported file has no snapshots (given they cannot be parsed). Hoping this will finally fix things