feat: better CSS parsing #21978
Merged
feat: better CSS parsing #21978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Apr 30, 2024
| --- /dev/null | ||
| +++ b/es/rrweb/packages/rrweb-snapshot/es/css.js | ||
| @@ -0,0 +1,87 @@ | ||
| +import postcss from '../../../../../../../../../postcss/lib/postcss.js' |
There was a problem hiding this comment.
Directory is after the patch is applied e.g. node_modules/.pnpm/rrweb@2.0.0-alpha.13_patch_hash=6bgnomayryopibyfydha2z5wbi/node_modules/rrweb/es/rrweb/packages/rrweb-snapshot/es
daibhin
commented
Apr 30, 2024
patches/rrweb@2.0.0-alpha.13.patch
Outdated
| - whitespace(); | ||
| - while (css[0] == '}') { | ||
| - error('extra closing bracket'); | ||
| - css = css.slice(1); | ||
| - whitespace(); | ||
| - } | ||
| - const m = match(/^(("(?:\\"|[^"])*"|'(?:\\'|[^'])*'|[^{])+)/); | ||
| + const m = match(/^([^{]+)/); |
There was a problem hiding this comment.
Diff gets a little funky here because we are removing a previously applied patch
daibhin
commented
Apr 30, 2024
patches/rrweb@2.0.0-alpha.13.patch
Outdated
| } | ||
|
|
||
| -const commentre = /\/\*[^*]*\*+([^/*][^*]*\*+)*\//g; | ||
| -function parse(css, options = {}) { |
There was a problem hiding this comment.
Removes all the old ast generation code because of a naming clash
marandaneto
approved these changes
Apr 30, 2024
|
This is huge, hopefully its a smooth patch 😅 |
daibhin
force-pushed
the
dn-feat/better-css-parsing
branch
from
87a5c0b to
a756743
Compare
|
@marandaneto I got scared 🙈 added a try / catch with the existing code that it should fall back to in production. Going to ship once 🍏 |
Very clever 🚀 |
|
Change is live and everything works as expected 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Towards #18520
Changes
postcssnode module inposthogand reference code from within a patch applied to therrwebpackageDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
postcssis tree shaken in production and cannot be accessed 🤔