fix: pin xmlsec to fixed version #22394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I faced the dreaded xmlsec issue again:
Previous attempt #22000
Changes
The original tracking issue has now been resolved as of xmlsec/python-xmlsec#284
Following SAML-Toolkits/python3-saml#389 (comment), we can explicitly set a version of
xmlsec
so everything just worksWe also need to upgrade
lxml
or we get thexmlsec.InternalError: (-1, 'lxml & xmlsec libxml2 library version mismatch')
error. There are no breaking changes when upgrading to the latest version: https://lxml.de/5.0/changes-5.0.2.htmlDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
No more errors when running locally