feat: add flag and onboarding steps for dashboard templates #23069

raquelmsmith · 2024-06-18T21:49:07Z

Problem

The first two steps of #23065

Add feature flag that this can be developed behind
Add dashboard template selector and configurator to onboarding steps

Changes

This just makes it barely functional. Adds the ability to select and create a dashboard from a template in the onboarding flow.

Screen.Recording.2024-08-28.at.3.14.56.PM.mov

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Behind a flag so is fine, but will need to make sure it doesn't show up for self-hosted in the future since they don't have the templates built in.

How did you test this code?

👀

github-actions · 2024-06-18T21:58:57Z

Size Change: +1.5 kB (+0.14%)

Total Size: 1.08 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	1.08 MB	+1.5 kB (+0.14%)

_{compressed-size-action}

posthog-bot · 2024-06-18T22:05:33Z

📸 UI snapshots have been updated

5 snapshot changes in total. 0 added, 5 modified, 0 deleted:

chromium: 0 added, 5 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…/github.com/PostHog/posthog into feat/rms/dashboard-template-onboarding-step

posthog-bot · 2024-06-20T03:16:49Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-20T03:31:36Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-20T03:47:38Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-20T04:03:45Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-20T04:19:19Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions

Size Change: +163 B (+0.02%)

Total Size: 1.06 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	1.06 MB	+163 B (+0.02%)

_{compressed-size-action}

posthog-bot · 2024-06-20T04:34:49Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-20T04:50:55Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-06-20T05:06:31Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-07-10T07:31:10Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

posthog-bot · 2024-07-18T07:31:06Z

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

posthog-bot · 2024-08-28T18:41:08Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…/github.com/PostHog/posthog into feat/rms/dashboard-template-onboarding-step

frontend/src/scenes/onboarding/productAnalyticsSteps/DashboardTemplateSelectStep.tsx

frontend/src/scenes/onboarding/Onboarding.tsx

Co-authored-by: Zach Waterfield <zlwaterfield@gmail.com>

raquelmsmith added 2 commits June 18, 2024 13:32

stub out the onboarding steps, use feature flag

6cca877

sort out step navigation

bcf75df

raquelmsmith changed the title ~~feat:~~ feat: add flag and onboarding steps for dashboard templates Jun 18, 2024

github-actions bot added 2 commits June 18, 2024 22:03

Update UI snapshots for chromium (1)

8f8fec9

Update UI snapshots for chromium (2)

611b608

raquelmsmith and others added 3 commits June 19, 2024 20:00

make it work on different steps, hacky style

5b1f52b

Merge branch 'feat/rms/dashboard-template-onboarding-step' of https:/…

86fd1a4

…/github.com/PostHog/posthog into feat/rms/dashboard-template-onboarding-step

Update UI snapshots for chromium (2)

1774f67

Update UI snapshots for chromium (1)

f0c619c

Update UI snapshots for chromium (2)

4257fa4

github-actions bot added 2 commits June 20, 2024 04:01

Update UI snapshots for chromium (1)

a1cde2b

Update UI snapshots for chromium (2)

fa26e7b

github-actions bot added 2 commits June 20, 2024 04:17

Update UI snapshots for chromium (1)

f6c622b

Update UI snapshots for chromium (2)

0ada9a6

github-actions bot reviewed Jun 20, 2024

View reviewed changes

Update UI snapshots for chromium (2)

4909fbe

github-actions bot added 2 commits June 20, 2024 04:48

Update UI snapshots for chromium (1)

64b357c

Update UI snapshots for chromium (2)

175a90a

Update UI snapshots for chromium (2)

2cef1cb

Update UI snapshots for chromium (2)

ffdd14d

This was referenced Jul 3, 2024

Sprint - June 24 to July 5, 2024 #23075

Closed

Sprint - July 8 to July 19, 2024 #23325

Closed

posthog-bot added the stale label Jul 10, 2024

zlwaterfield mentioned this pull request Jul 17, 2024

Sprint - Jul 22 to Aug 2, 2024 #23768

Closed

posthog-bot closed this Jul 18, 2024

raquelmsmith mentioned this pull request Jul 31, 2024

Sprint - Aug 5 to Aug 16 #24105

Closed

raquelmsmith mentioned this pull request Aug 14, 2024

Sprint - Aug 19 to Aug 30 #24364

Closed

raquelmsmith mentioned this pull request Aug 28, 2024

Sprint - Sept 2 to Sept 13 #24633

Closed

raquelmsmith reopened this Aug 28, 2024

raquelmsmith and others added 2 commits August 28, 2024 11:24

Merge branch 'master' into feat/rms/dashboard-template-onboarding-step

2db8278

Update UI snapshots for chromium (1)

d4b6b4c

raquelmsmith added 4 commits August 28, 2024 14:12

fix error

998c6f5

fix redirect after creation with no vars

6d4cc61

Merge branch 'feat/rms/dashboard-template-onboarding-step' of https:/…

568a5a8

…/github.com/PostHog/posthog into feat/rms/dashboard-template-onboarding-step

fix types

e146013

raquelmsmith requested a review from zlwaterfield August 28, 2024 22:57

raquelmsmith marked this pull request as ready for review August 28, 2024 22:57

posthog-bot removed the stale label Aug 29, 2024

zlwaterfield approved these changes Aug 29, 2024

View reviewed changes

frontend/src/scenes/onboarding/productAnalyticsSteps/DashboardTemplateSelectStep.tsx Show resolved Hide resolved

frontend/src/scenes/onboarding/Onboarding.tsx Show resolved Hide resolved

raquelmsmith and others added 3 commits August 29, 2024 10:18

Apply suggestions from code review

f209c42

Co-authored-by: Zach Waterfield <zlwaterfield@gmail.com>

actually, these can't be in a jsx fragment

bccc24d

this only works this way as well :D

1b797c2

raquelmsmith enabled auto-merge (squash) August 29, 2024 17:41

raquelmsmith merged commit 719950b into master Aug 29, 2024
92 checks passed

raquelmsmith deleted the feat/rms/dashboard-template-onboarding-step branch August 29, 2024 17:55

raquelmsmith mentioned this pull request Aug 30, 2024

feat: Dashboard templates in onboarding #23065

Open

29 tasks

raquelmsmith mentioned this pull request Sep 11, 2024

Sprint - Sept 16 to Sept 27 #24890

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add flag and onboarding steps for dashboard templates #23069

feat: add flag and onboarding steps for dashboard templates #23069

raquelmsmith commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading

posthog-bot commented Jun 18, 2024

posthog-bot commented Jun 20, 2024

posthog-bot commented Jun 20, 2024

posthog-bot commented Jun 20, 2024

posthog-bot commented Jun 20, 2024

posthog-bot commented Jun 20, 2024

github-actions bot left a comment

posthog-bot commented Jun 20, 2024

posthog-bot commented Jun 20, 2024

posthog-bot commented Jun 20, 2024

posthog-bot commented Jul 10, 2024

posthog-bot commented Jul 18, 2024

posthog-bot commented Aug 28, 2024

feat: add flag and onboarding steps for dashboard templates #23069

feat: add flag and onboarding steps for dashboard templates #23069

Conversation

raquelmsmith commented Jun 18, 2024 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

github-actions bot commented Jun 18, 2024 • edited Loading

posthog-bot commented Jun 18, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

github-actions bot left a comment

Choose a reason for hiding this comment

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jun 20, 2024

📸 UI snapshots have been updated

posthog-bot commented Jul 10, 2024

posthog-bot commented Jul 18, 2024

posthog-bot commented Aug 28, 2024

📸 UI snapshots have been updated

raquelmsmith commented Jun 18, 2024 •

edited

Loading

github-actions bot commented Jun 18, 2024 •

edited

Loading