-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hog): bytecode versions #24584
feat(hog): bytecode versions #24584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looked at tests. I'm assuming then at some point we will need a migration layer to ensure backwards compat? I couldn't quite parse in all the code if there is a chance other than supporting a version index?
Other than the version integer in the bytecode, the code also 1) flips around the arguments in function calls when using the new version, 2) changes CALL to CALL_GLOBAL, 3) throws on undefined global access All of it is effectively housekeeping in order to make the next extracted PR (actually lambdas and function refactors) easier to swallow. We won't need a migration as long as we keep the |
This reverts commit b7105b6.
Problem
Continuing extraction from #24369
Changes
op.CALL
toop.CALL_GLOBAL
How did you test this code?
Updated many tests