-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hog): Hog bytecode function STL #24653
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
Gilbert09
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Final go at getting
arrayMap
,arrayExists
andarrayFilter
working.Changes
arrayMap.hog
,arrayExists.hog
andarrayFilter.hog
STL functionsbin/hog --out file.hog
that prints the bytecode into stdoutHow did you test this code?
Added several tests
Alternatives considered
arrayMap
in native python/typescript and letting it call back into Hog when it needs to run a closure. This worked, but we could no longer serialize and resume the VM, if a native function is somewhere in the call stack. Seemed like a weird constraint to impose and explain.arrayMap
seem universal enough that the VM should know about them. No need to bloat every bytecode that uses it. There were some implementation quirks making it difficult (e.g. functions can't call each other)