feat: recordings ordering #24794

daibhin · 2024-09-04T17:37:17Z

Problem

Order replays!

Randomly choose replays! (closes #8182)

Changes

Add ordering back to replay filtering
Add more options to filter by (activity mainly)
Remove ability to customise "duration shown" (it uses the ordering duration or the total duration now)
Rewrite query such that it doesn't need to be parsed
- Curious if this has any performance impact
Removed some legacy stuff about changing the search period (we should always respect the date range filter first and foremost)

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added a test

neilkakkar

nice, some failing tests w.r.t assigning start_time instead of latest it looks like

daibhin · 2024-09-05T10:04:15Z

@neilkakkar requested a re-review because I added in the random sample stuff and felt like things had changed enough. Will comment where things have changed

daibhin · 2024-09-05T10:06:18Z

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.test.ts

@@ -54,7 +73,7 @@ describe('sessionRecordingsPlaylistLogic', () => {
                        return [
                            200,
                            {
-                                results: [`List of recordings offset by ${listOfSessionRecordings.length}`],


The sortRecordings function did not like that this was not an object

daibhin · 2024-09-05T10:07:15Z

posthog/session_recordings/queries/session_recording_list_from_filters.py

+
+    def _order_by_clause(self) -> ast.OrderExpr:
+        expr = (
+            ast.Call(name="sipHash64", args=[ast.Field(chain=["session_id"])])


Main addition here @neilkakkar. Idea is that it generates a hash based on the session id and uses that to pick a random but (mostly deterministic) ordering of recordings

this seems unnecessary 🤔 , unless the worry is around pagination here? You can do order by rand() if you just want a random sampling.

Yeah, was trying to keep things consistent around pagination, link sharing and repeated runs

since the hash is consistent, does this mean the first page after you select random will always be the same? 😅 Again not sure if this is more confusing than it changing every time (and then being able to sort that result list).

I think we can relax the product constraint of pagination working appropriately when random sampling is chosen perhaps.

as a user I'd potentially like to be like a gacha, every time I click the toggle I get different recordings

i commented elsewhere but i'll add it here so there's one thread :)

i don't think I get random... why?

(it also feels wrong that it's consistently random, if i toggle it on and off i get the same random list each time)

ah, ok, i read the linked issue... fair enough :)

let's make sure we get metrics on what people are choosing / loading ??

github-actions · 2024-09-05T10:26:32Z

Size Change: 0 B

Total Size: 1.1 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	1.1 MB

_{compressed-size-action}

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts

pauldambra · 2024-09-05T17:57:22Z

frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylistSettings.tsx

+                        },
+                    ]}
+                    size="small"
+                    value={orderBy as string}


could probably avoid this cast by properly typing the options but they're nested and i'm lazy 🤣

pauldambra · 2024-09-05T17:58:14Z

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts

@@ -417,7 +429,14 @@ export const sessionRecordingsPlaylistLogic = kea<sessionRecordingsPlaylistLogic
            'start_time' as RecordingsQuery['order'],
            { persist: true },
            {
-                setOrderBy: (_, { orderBy }) => orderBy,
+                setOrderBy: (_, { orderBy }) => orderBy as RecordingsQuery['order'],


casting here to make other typing easier. it's still protected by the typing on the setOrderBy param

pauldambra · 2024-09-05T17:58:48Z

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts

+                setOrderBy: (_, { orderBy }) => orderBy as RecordingsQuery['order'],
+            },
+        ],
+        randomSample: [


I don't think I get the use for random sample (especially since it appears to be a persistent randomness when toggling the sampling on and off)

Original thinking was in #8182

Tbh I might just remove it for now because I can foresee it causing customer confusion if there's misunderstanding about it and it hasn't made it past the PR 😅

Yeah, the 8182 is "matching examples from a wider date range"

i.e. not each consecutive recording, not random recordings, just one from each day or whatever

considering it's not come up again, i'd strip it out of here, yep

then we can test if selecting something other then latest for people affects behaviour - which is what i'm really excited about

do people choose this themselves

what happens if we choose it for them

that's why i'd suggest making it front and center so we can see if they change away as well

well, top and right not front and center 🤣

pauldambra

feel free to change my typing, er, typing

pauldambra · 2024-09-05T18:12:12Z

frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx

commenting here so we can thread if need be

high quality photoshop warning

should it be here (but not beige)

oh... and we have a random sample toggle, and a random ordering in the menu... so i can choose random random 🤔

Hesitant to put something on that level in case it ends up getting muddled with a large amount of filters. Going to go with something like this instead:

Experimented with an even more natural language based approach but I don't think it quite works because of our button paddings

… into dn-feat/replay-filtering

posthog-bot · 2024-09-06T11:17:47Z

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

chromium: 0 added, 4 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-09-09T11:20:37Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-09-09T13:40:47Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1, diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-09-09T14:19:34Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

daibhin added 9 commits September 3, 2024 15:31

include ordering clause

fd6ea28

remove durationToShow and rely on ordering

5183a11

remove earliest and correct order when merging

77a7ceb

cleanup function

cc482df

Merge branch 'master' into dn-feat/replay-filtering

108d492

inline header actions

91653a7

incomparible filters

874d3cc

Merge branch 'master' into dn-feat/replay-filtering

f34c534

add test

6e92bf6

daibhin changed the title ~~include ordering clause~~ feat: recordings ordering Sep 4, 2024

daibhin requested a review from a team September 4, 2024 17:38

daibhin added 2 commits September 4, 2024 18:59

Merge branch 'master' into dn-feat/replay-filtering

10c4a74

feat: random sample recordings order

841d907

neilkakkar approved these changes Sep 5, 2024

View reviewed changes

daibhin added 3 commits September 5, 2024 09:32

Merge branch 'master' into dn-feat/replay-filtering

e5f62bb

rename latest to start_time

635ef6f

much cleaner tests

dd6baf2

daibhin requested a review from neilkakkar September 5, 2024 10:02

daibhin force-pushed the dn-feat/replay-filtering branch from 72b533e to dd6baf2 Compare September 5, 2024 10:03

fix name

5629032

daibhin commented Sep 5, 2024

View reviewed changes

daibhin and others added 3 commits September 5, 2024 11:08

remove comment

971b590

Update query snapshots

e79b621

Update query snapshots

16c9a56

Update query snapshots

93c56af

neilkakkar reviewed Sep 5, 2024

View reviewed changes

frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts Outdated Show resolved Hide resolved

Update query snapshots

347e0ea

github-actions bot and others added 2 commits September 5, 2024 17:51

Update query snapshots

288488e

Fangle types

437d1e0

pauldambra reviewed Sep 5, 2024

View reviewed changes

pauldambra approved these changes Sep 5, 2024

View reviewed changes

pauldambra reviewed Sep 5, 2024

View reviewed changes

daibhin and others added 9 commits September 6, 2024 10:58

Merge branch 'master' into dn-feat/replay-filtering

b8cfa22

remove random sampling

dbd6b65

Update query snapshots

8287d70

move ordering

5fa2c25

Merge branch 'dn-feat/replay-filtering' of github.com:PostHog/posthog…

b8dae38

… into dn-feat/replay-filtering

update snapshots

bf04127

Update query snapshots

bcf3aee

Update UI snapshots for chromium (1)

1971815

Update UI snapshots for chromium (2)

c0db65b

daibhin and others added 2 commits September 9, 2024 12:03

Merge branch 'master' into dn-feat/replay-filtering

c920e67

Update UI snapshots for chromium (1)

4c4470b

daibhin and others added 4 commits September 9, 2024 14:22

Merge branch 'master' into dn-feat/replay-filtering

2452f83

reset snapshots

b637a33

Update UI snapshots for chromium (1)

aabb1eb

Update UI snapshots for chromium (2)

ed64528

daibhin and others added 2 commits September 9, 2024 15:00

Merge branch 'master' into dn-feat/replay-filtering

47a93f1

Update UI snapshots for chromium (1)

d79ae5c

daibhin merged commit f855d23 into master Sep 10, 2024
93 checks passed

daibhin deleted the dn-feat/replay-filtering branch September 10, 2024 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: recordings ordering #24794

feat: recordings ordering #24794

daibhin commented Sep 4, 2024 •

edited

Loading

neilkakkar left a comment •

edited

Loading

daibhin commented Sep 5, 2024

daibhin Sep 5, 2024

daibhin Sep 5, 2024 •

edited

Loading

neilkakkar Sep 5, 2024

daibhin Sep 5, 2024

neilkakkar Sep 5, 2024

neilkakkar Sep 5, 2024

pauldambra Sep 5, 2024

pauldambra Sep 5, 2024

pauldambra Sep 5, 2024

github-actions bot commented Sep 5, 2024 •

edited

Loading

pauldambra Sep 5, 2024

pauldambra Sep 5, 2024

pauldambra Sep 5, 2024

daibhin Sep 5, 2024

pauldambra Sep 5, 2024

pauldambra Sep 5, 2024

pauldambra left a comment

pauldambra Sep 5, 2024

pauldambra Sep 5, 2024

daibhin Sep 6, 2024

pauldambra Sep 6, 2024

posthog-bot commented Sep 6, 2024

posthog-bot commented Sep 9, 2024

posthog-bot commented Sep 9, 2024

posthog-bot commented Sep 9, 2024

feat: recordings ordering #24794

feat: recordings ordering #24794

Conversation

daibhin commented Sep 4, 2024 • edited Loading

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

neilkakkar left a comment • edited Loading

Choose a reason for hiding this comment

daibhin commented Sep 5, 2024

Choose a reason for hiding this comment

daibhin Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pauldambra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

posthog-bot commented Sep 6, 2024

📸 UI snapshots have been updated

posthog-bot commented Sep 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Sep 9, 2024

📸 UI snapshots have been updated

posthog-bot commented Sep 9, 2024

📸 UI snapshots have been updated

daibhin commented Sep 4, 2024 •

edited

Loading

neilkakkar left a comment •

edited

Loading

daibhin Sep 5, 2024 •

edited

Loading

github-actions bot commented Sep 5, 2024 •

edited

Loading