-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support HLS media playback #25174
Conversation
Size Change: +87 B (+0.01%) Total Size: 1.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the question about the url, this is a great fix
@daibhin thanks for the quick fix! Unfortunately I'm not sure how to test this is working, using the "hobby" docker version of PostHog. I added the Then did the following:
Still seeing the original issue after the steps above. I searched( |
Hey @MannyAdumbire, do you have a link to one of the affected recordings? Just trying to recreate this locally on my machine but might be quicker to use one of your examples if you have one to hand |
You're right @MannyAdumbire, I hadn't anticipated that a HLS video would add a |
@daibhin I finally figured out how to update the hobby version container to get built with the latest posthog-js. |
Amazing! Did it require any changes on your end beyond upgrading the version? I would love to update our docs if there's anything that might help others to make this work |
Sorry that I don't quite remember the key steps 😅
I wish I know what the minimal list of docker services needing to be rebuilt is, but each one I tried complained with some docker message about dependent container being affected. This rough upgrade worked fine for a while but then I run into an issue that seemed to only resolve with the full upgrade mentioned in #25262 (comment) |
Problem
HLS media playback is not supported in Replay right now because the
src
is not added to the DOM and thus not captured by rrwebChanges
Implementation as described in #25087 (comment)
Key thing to note is that the media source must be added as a
hls-src
attribute on the video element (needs to be added to the docs once this is testred)How did you test this code?
Tested video plays back locally