refactor: Use heartbeat date ranges to track progress #26094
+1,583
−436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasfarias
force-pushed
the
feat/range-heartbeats-for-batch-exports
branch
3 times, most recently
from
d8d5013
to
e0c7575
Compare
tomasfarias
force-pushed
the
feat/range-heartbeats-for-batch-exports
branch
from
e3aec8e
to
59e0a7f
Compare
tomasfarias
force-pushed
the
feat/range-heartbeats-for-batch-exports
branch
from
975ff4f
to
ce6ecdf
Compare
tomasfarias
force-pushed
the
feat/range-heartbeats-for-batch-exports
branch
from
20189af
to
a866795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tracking progress in a world with multiple simultaneous flushes to destinations is impossible to do with just a single cursor (
last_inserted_at). As flushes could finish out of order, increasing the cursor could be silently dropping data from flushes that would have finish later but are contain earlier data, if a worker were to crash at the right (or wrong) time.Changes
This PR changes our implementation of hearbeating a single cursor value to heartbeating ranges, date ranges.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Added a bunch of tests.