feat: making role in organization as a required field

[surbhi-posthog]

Problem

since we want to understand the type of users using our product, having the role information is crucial and we want to try to make it as a required field.

Changes

Comparison: Before vs. After

Before	After
The role was optional	Changes don't allow the user to proceed without adding in a role.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

self-hosted

How did you test this code?

Tested locally after commenting out the signup reroute in sceneLogic.ts. I verified that a new user was created and could access their posthog account.

           // if (scene === Scene.Signup && preflight && !preflight.can_create_org) {
            //     // If user is on an already initiated self-hosted instance, redirect away from signup
            //     router.actions.replace(urls.login())
            //     return
            // }

NOTE:
ran DEBUG=1 CLOUD_DEPLOYMENT=1 bin/start to clear the authentication credential issue when there are more than one users created in the same flow

[github-actions]

Size Change: 0 B

Total Size: 1.15 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	1.15 MB

_{compressed-size-action}

[patricio-posthog]

Not a React expert, but it looks good to me :)

[zlwaterfield]

Yeah, you're learning kea!

[zlwaterfield]

@surbhi-posthog after you fix something feel free to re-request a review.

For the failed E2E test, click into it and see if it's related to your change, if not you can try to re-run as it may be a flakey test.

[surbhi-posthog]

@zlwaterfield, i've added the changes to the cypress tests and they now pass. Could you take another look at this?

In the meantime, I'm fixing the xmlsec issue on my local and verifying if cleaning the volumes and containers in orbstack fixes the authentication credential issue.

[zlwaterfield]

Nice work! LGTM.

[surbhi-posthog]

I ran DEBUG=1 CLOUD_DEPLOYMENT=1 bin/start and cleared authentication credential issue