feat(web-analytics): Add UI to choose custom channel types #26284
+1,455
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
force-pushed
the
feature/add-ui-to-choose-channel-types
branch
from
5719e07
to
7230a1a
Compare
|
Size Change: +894 B (+0.08%) Total Size: 1.16 MB ℹ️ View Unchanged
|
robbie-c
force-pushed
the
feature/add-ui-to-choose-channel-types
branch
from
9404a8e
to
9d3d911
Compare
robbie-c
force-pushed
the
feature/add-ui-to-choose-channel-types
branch
from
fc97a72
to
9b68150
Compare
robbie-c
force-pushed
the
feature/add-ui-to-choose-channel-types
branch
from
557f24a
to
5315025
Compare
robbie-c
commented
Nov 22, 2024
| TouchSensor, | ||
| useSensor, | ||
| useSensors, | ||
| } from '@dnd-kit/core' |
There was a problem hiding this comment.
I used dnd kit for this as we already use it as a dependency elsewhere. Most of this file is modified examples that they provide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For context: #21195
This PR is the UI side, the back end side was done here: #26181
Changes
Still behind an FF, the plan is to release it for us and dogfood before turning it on for anyone
I can create custom channel types here:
Which I can see in queries:
(this is matching traffic with utm_source=google)
Here's a longer video
https://github.com/user-attachments/assets/fe201b21-b536-4e7c-883e-e4c55cf1bfb7
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
The backend changes have test in the other PR
The UI component I made for this has a storybook snapshot