Skip to content

feat(cdp): update node version in ci #32983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Jun 2, 2025

Important

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

Corepack is broken with 18.12.1

Let's see if we can easily upgrade the version?

Changes

Did you write or update any docs for this change?

How did you test this code?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates Node.js version from 18.12.1 to v18.20.6 across all CI workflow files to fix broken Corepack functionality while maintaining backward compatibility.

  • Consistently updates Node.js version in all CI workflow files including .nvmrc, .github/workflows/ci-e2e-playwright.yml, ci-frontend.yml, ci-plugin-server.yml, and others
  • Adds 'v' prefix to version numbers for better alignment with Node.js version conventions
  • Maintains version consistency within Node.js 18.x LTS branch for backward compatibility
  • Fixes specific Corepack functionality issues present in version 18.12.1

8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

github-actions bot commented Jun 2, 2025

Size Change: 0 B

Total Size: 3.74 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.74 MB

compressed-size-action

@MarconLP MarconLP closed this Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant