Skip to content

Commit

Permalink
ci: Be explicit about the version of linux and windows runner images
Browse files Browse the repository at this point in the history
Using the -latest tag is potentially prone to errors, because an update of the tag
could break our CI. This recently happend with macos-latest, which we downgraded
to macos-12 earlier.

Using an explicit version reference makes this problem much less likely - in fact
renovate will pick up new versions once they exist and will suggest updates for it.
Thus, we will see the failures in a related PR instead of randomly everywhere.
  • Loading branch information
wolfgangwalther committed Apr 22, 2024
1 parent dcb9f92 commit 6858693
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 20 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ concurrency:
jobs:
static:
name: Nix - Linux static
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Nix Environment
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
matrix:
include:
- name: Linux
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
cache: |
~/.stack
.stack-work
Expand All @@ -102,7 +102,7 @@ jobs:
artifact: postgrest-macos-x64

- name: Windows
runs-on: windows-latest
runs-on: windows-2022
cache: |
~\AppData\Roaming\stack
~\AppData\Local\Programs\stack
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:

freebsd:
name: Stack - FreeBSD from CirrusCI
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Get FreeBSD executable from CirrusCI
Expand All @@ -164,7 +164,7 @@ jobs:
ghc: ['9.6.4', '9.8.2']
fail-fast: false
name: Cabal - Linux GHC ${{ matrix.ghc }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: ghcup
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:
jobs:
lint-style:
name: Lint & Style
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Nix Environment
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
arm:
name: Build / Cabal - aarch64 GHC 9.4.8
if: vars.SSH_ARM_ENABLED
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
remotepath: ${{ steps.Remote-Dir.outputs.remotepath }}
env:
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
if: |
startsWith(github.ref, 'refs/tags/v') &&
(success() || needs.arm.result == 'skipped')
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- docs
- test
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
name: Release / GitHub
permissions:
contents: write
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: prepare
env:
VERSION: ${{ needs.prepare.outputs.version }}
Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
docker:
name: Release / Docker Hub
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- prepare
env:
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:

docker-arm:
name: Release / Docker Hub Arm
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs:
- arm
- prepare
Expand Down Expand Up @@ -316,7 +316,7 @@ jobs:
- arm
- docker-arm
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
REMOTE_DIR: ${{ needs.arm.outputs.remotepath }}
steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ concurrency:
jobs:
build:
name: Build
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Nix Environment
Expand All @@ -39,7 +39,7 @@ jobs:

spellcheck:
name: Spellcheck
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Nix Environment
Expand All @@ -56,7 +56,7 @@ jobs:
linkcheck:
name: Linkcheck
if: github.base_ref == 'main'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Nix Environment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
name: Loadtest
permissions:
checks: write
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
if: github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure'
steps:
- name: Download from Artifacts
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ concurrency:
jobs:
coverage:
name: Coverage
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
defaults:
run:
# Hack for enabling color output, see:
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
matrix:
pgVersion: ["9_6", 10, 11, 12, 13, 14, 15, 16]
name: PG ${{ matrix.pgVersion }}
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
defaults:
run:
# Hack for enabling color output, see:
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:

memory:
name: Memory
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Setup Nix Environment
Expand All @@ -112,7 +112,7 @@ jobs:

loadtest:
name: Loadtest
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
with:
Expand Down

0 comments on commit 6858693

Please sign in to comment.