-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split nix-build-test into nix-build nix-test and introduce circle ci contexts #1817
ci: split nix-build-test into nix-build nix-test and introduce circle ci contexts #1817
Conversation
c560f6b
to
d7d4c3c
Compare
(I cancelled the nix steps for now, because the cache is not built up again, yet) |
Just noticed that we seem to have a limit of 4 jobs running in parallel on circle. Not too much of a problem because |
👍 For that. A single stack job should be enough, we just need to make sure it builds(so stackage can notify robx of dependency changes). |
6614c85
to
61c1bf3
Compare
@monacoremo Are we still missing some of the cache? |
Yes, noticed that some of the static build assets were not pushed yet. Running that now |
61c1bf3
to
3cff3fc
Compare
Also added a checksum check for the codecov bash script and reordered The tokens are still going to be available through regular environment variables for now. @steve-chavez once you have added the new tokens to the contexts, you can remove the old ones from the env vars. I suggest you then trigger a nightly build - that should test whether context + tokens work fine. Since we can't test it in the PR anyway, because the tokens won't be used here, I'm going to merge this now. |
Actually, I will wait for @monacoremo to build the remaining cache and then merge to avoid a long running build job on main. Let me know! |
This fixes issue PostgREST#1817, Add Retry-After hint when in recovery mode
Add Retry-After header when response status is 503. Its value is the connection worker delay(seconds) when it's recovering. This closes issue #1817.
As discussed via email. This is to secure our cachix, docker and github tokens better. Contexts will still have to be filled with environment variables.
The split in
nix-build
andnix-test
should also make our pipeline faster, because they can both run in parallel. @monacoremo Did I miss anything in there? I don't think thenix-build
step will have any problems, but will that be OK fornix-test
? Or is it missing anything that I removed in that step?