RPC returning table alias now works for pg 11/12 #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new LATERAL query used for calling the function, introduced on PostgREST#2677, failed on functions that returned a domain like `CREATE DOMAIN projects_domain AS projects`. Work around that by changing the query conditionally, by obtaining a bool that represents the composite alias on the SchemaCache and only do this on pg 11 and 12.
steve-chavez
commented
Apr 5, 2023
| @@ -376,8 +376,7 @@ spec actualPgVersion = | |||
| ]|] | |||
| { matchHeaders = [matchContentTypeJson] } | |||
|
|
|||
| -- https://github.com/PostgREST/postgrest/pull/2677#issuecomment-1444976849 | |||
| when (actualPgVersion >= pgVersion130) $ | |||
| when (actualPgVersion >= pgVersion110) $ | |||
There was a problem hiding this comment.
This is the main thing. These tests now pass for pg 11 and 12.
laurenceisla
reviewed
Apr 5, 2023
Co-authored-by: Laurence Isla <vanquisher.laurence.02@gmail.com>
laurenceisla
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new LATERAL query used for calling the function, introduced on #2677, failed on functions that returned a domain like
CREATE DOMAIN projects_domain AS projects.Work around that by changing the query conditionally, by obtaining a bool that represents the composite alias on the SchemaCache and only do this on pg 11 and 12.