ci: Improve github actions workflows #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…artifact The "default" action now supports downloading from different workflow runs, too, so we might as well use it.
wolfgangwalther
force-pushed
the
workflows
branch
4 times, most recently
from
9018ee2 to
dce0c62
Compare
…ng main The previous setup would cause multiple commits on main to be stuck in a pending state, waiting for the previous run to be finished. The new group specification is taken from: https://docs.github.com/en/actions/using-jobs/using-concurrency#example-using-a-fallback-value This also adds the same settings for the docs workflow.
While this duplicates code a little bit, it makes it much simpler to refactor later on.
wolfgangwalther
force-pushed
the
workflows
branch
from
dce0c62 to
6cbd086
Compare
wolfgangwalther
force-pushed
the
workflows
branch
from
6cbd086 to
f110817
Compare
Both jobs run really quick, running them separate is just a waste of resources. Plus, they are semantically closely related anyway.
This TODO will have to wait until later. Will need to simplify the whole ARM job first, when our self-hosted GitHub Runner works. Too many dependencies between jobs in that area. |
|
The FreeBSD build is still executing when only the docs are changed. https://github.com/PostgREST/postgrest/pull/3296/checks?check_run_id=22142036339 Only FreeBSD, the rest is working perfectly. |
Right, I noticed a few days ago as well. I think it's somewhere on my list, but thanks for the reminder :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make Pull Requests run only those jobs they need to run, i.e. a docs-only PR should only run the docs jobs. A PR only touching tests, should only run the test-related jobs, and a PR touching code should run both Build and Test jobs.
GitHub Actions only allows
pathson the workflow level, thus to achieve this, I had to split the whole thing into multiple workflows. This comes with it's own set of challenges, though, because especially the release jobs need to wait for the other jobs to finish, so they can't just run in parallel. Also, artifacts need to be available from build to release. To achieve this, we are using "Reusable Workflows" - i.e. the build, docs and test workflows are now run on their own in a PR - but as a nested workflow on any push event.TLDR:
TODO: